hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-1055) FINDBUGS: remaining "Dodgy Warnings"
Date Thu, 29 Oct 2009 14:47:59 GMT

    [ https://issues.apache.org/jira/browse/PIG-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771433#action_12771433
] 

Hadoop QA commented on PIG-1055:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423487/PIG-1055.patch
  against trunk revision 830757.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/29/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/29/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/29/console

This message is automatically generated.

> FINDBUGS: remaining "Dodgy Warnings"
> ------------------------------------
>
>                 Key: PIG-1055
>                 URL: https://issues.apache.org/jira/browse/PIG-1055
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Olga Natkovich
>            Assignee: Olga Natkovich
>         Attachments: PIG-1055.patch
>
>
> BC 	Questionable cast from java.util.List to java.util.ArrayList in new org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigSplit(PigContext,
FileSystem, Path, String, List, long, long)
> Eq 	org.apache.pig.data.AmendableTuple doesn't override DefaultTuple.equals(Object)
> Eq 	org.apache.pig.data.TimestampedTuple doesn't override DefaultTuple.equals(Object)
> IA 	Ambiguous invocation of either an outer or inherited method org.apache.pig.impl.plan.DotPlanDumper.getName(Operator)
in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.plans.DotMRPrinter$InnerPrinter.getAttributes(DotMRPrinter$InnerOperator)
> IM 	Computation of average could overflow in org.apache.tools.bzip2r.CBZip2OutputStream.qSort3(int,
int, int)
> IM 	Check for oddness that won't work for negative numbers in org.apache.tools.bzip2r.CBZip2OutputStream.sendMTFValues()
> REC 	Exception is caught when Exception is not thrown in org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.doHod(String,
Properties)
> REC 	Exception is caught when Exception is not thrown in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.CombinerOptimizer.visitMROp(MapReduceOper)
> REC 	Exception is caught when Exception is not thrown in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.visitDistinct(PODistinct)
> REC 	Exception is caught when Exception is not thrown in org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MRCompiler.visitFRJoin(POFRJoin)
> REC 	Exception is caught when Exception is not thrown in org.apache.pig.impl.logicalLayer.optimizer.OpLimitOptimizer.processNode(LOLimit)
> REC 	Exception is caught when Exception is not thrown in org.apache.pig.tools.streams.StreamGenerator.actionPerformed(ActionEvent)
> ST 	Write to static field org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner.sJobConf
from instance method org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigCombiner$Combine.configure(JobConf)
> ST 	Write to static field org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat.activeSplit
from instance method org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat.getRecordReader(InputSplit,
JobConf, Reporter)
> ST 	Write to static field org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat.sJob
from instance method org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigInputFormat.getRecordReader(InputSplit,
JobConf, Reporter)
> ST 	Write to static field org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapReduce.sJobConf
from instance method org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapBase.configure(JobConf)
> ST 	Write to static field org.apache.pig.data.BagFactory.gMemMgr from instance method
new org.apache.pig.data.BagFactory()
> ST 	Write to static field org.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper.mOpToCloneMap
from instance method new org.apache.pig.impl.logicalLayer.LogicalPlanCloneHelper(LogicalPlan,
Map)
> ST 	Write to static field org.apache.pig.impl.logicalLayer.LogicalPlanBuilder.classloader
from instance method org.apache.pig.impl.PigContext.addJar(URL)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message