hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-968) findContainingJar fails when there's a + in the path
Date Tue, 22 Sep 2009 19:52:16 GMT

    [ https://issues.apache.org/jira/browse/PIG-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758394#action_12758394
] 

Todd Lipcon commented on PIG-968:
---------------------------------

bq. You need to add a unit test that checks that this works when there is a + in the path.


This is very difficult to test - we'd need to add several more ant rules to build a jar into
the test directory with a + in it and get that on the classpath for tests. findContainingJar
itself is not currently tested.

bq. Also, a more general question: I'm guessing that '+' isn't the only mishandled character.
Are there others that should be checked?

It's well-known that URLDecoder actually decodes x-www-form-urlencoded rather than true URL
encoding. The spec for that encoding is here: http://www.w3.org/MarkUp/html-spec/html-spec_8.html#SEC8.2.1

As far as I've been able to find, '+' is the only difference, except for perhaps newlines
which can't occur in pathnames afaik.

More info here: http://en.wikipedia.org/wiki/Percent-encoding#The_application.2Fx-www-form-urlencoded_type

> findContainingJar fails when there's a + in the path
> ----------------------------------------------------
>
>                 Key: PIG-968
>                 URL: https://issues.apache.org/jira/browse/PIG-968
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.4.0, 0.5.0
>            Reporter: Todd Lipcon
>         Attachments: pig-968.txt
>
>
> This is the same bug as in MAPREDUCE-714. Please see discussion there.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message