hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-907) Provide multiple version of HashFNV (Piggybank)
Date Thu, 06 Aug 2009 09:15:14 GMT

    [ https://issues.apache.org/jira/browse/PIG-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739951#action_12739951
] 

Hadoop QA commented on PIG-907:
-------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12415534/PIG-907-2.patch
  against trunk revision 801460.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/148/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/148/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/148/console

This message is automatically generated.

> Provide multiple version of HashFNV (Piggybank)
> -----------------------------------------------
>
>                 Key: PIG-907
>                 URL: https://issues.apache.org/jira/browse/PIG-907
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Daniel Dai
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: PIG-907-1.patch, PIG-907-2.patch
>
>
> HashFNV takes 1 or 2 parameters. It is better to create 2 versions of HashFNV when PIG-902
is not solved. So we can let the Pig pick the right version, do the type cast. Otherwise,
user have to do the explicit cast. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message