hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-865) Performance: Unnnecessary computation in FRJoin
Date Sun, 28 Jun 2009 07:38:47 GMT

    [ https://issues.apache.org/jira/browse/PIG-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724929#action_12724929
] 

Hadoop QA commented on PIG-865:
-------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12412006/pig-865.patch
  against trunk revision 788174.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/105/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/105/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/105/console

This message is automatically generated.

> Performance: Unnnecessary computation in FRJoin
> -----------------------------------------------
>
>                 Key: PIG-865
>                 URL: https://issues.apache.org/jira/browse/PIG-865
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>    Affects Versions: 0.3.0
>            Reporter: Ashutosh Chauhan
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: pig-865.patch
>
>
> In POFRJoin implementation POLocalRearrange is used to extract join keys from the input
tuples. If keys match then to perform actual join input tuples are fed to Foreach which does
a cross on its inputs. After keys are extracted using POLocalRearrange output; function getValueTuple(POLocalRearrange
lr, Tuple tuple) is called to reconstruct the input tuple. It seems that this function call
is unnecessary since we already have input tuple at that time. 
> This is not a bug, but since this function would get called for every tuple, if it is
eliminated, it should certainly help to improve performance. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message