hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-802) PERFORMANCE: not creating bags for ORDER BY
Date Mon, 18 May 2009 22:05:45 GMT

    [ https://issues.apache.org/jira/browse/PIG-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710511#action_12710511
] 

Hadoop QA commented on PIG-802:
-------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12408398/OrderByOptimization.patch
  against trunk revision 775340.

    -1 @author.  The patch appears to contain 1 @author tags which the Pig community has agreed
to not allow in code contributions.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    -1 javac.  The applied patch generated 227 javac compiler warnings (more than the trunk's
current 226 warnings).

    -1 findbugs.  The patch appears to introduce 4 new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/47/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/47/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/47/console

This message is automatically generated.

> PERFORMANCE: not creating bags for ORDER BY
> -------------------------------------------
>
>                 Key: PIG-802
>                 URL: https://issues.apache.org/jira/browse/PIG-802
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Olga Natkovich
>         Attachments: OrderByOptimization.patch
>
>
> Order by should be changed to not use POPackage to put all of the tuples in a bag on
the reduce side, as the bag is just immediately flattened. It can instead work like join does
for the last input in the join. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message