hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pradeep Kamath (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-649) RandomSampleLoader does not handle skipping correctly in getNext()
Date Sat, 31 Jan 2009 01:44:59 GMT

     [ https://issues.apache.org/jira/browse/PIG-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Pradeep Kamath updated PIG-649:
-------------------------------

    Status: Patch Available  (was: Open)

The attached patch fixes the issue by keep track of the return value of the underlying input
stream's skip(). If enough bytes are not skipped on the initial call, multiple calls are made
till enough bytes are skipped

> RandomSampleLoader does not handle skipping correctly in getNext()
> ------------------------------------------------------------------
>
>                 Key: PIG-649
>                 URL: https://issues.apache.org/jira/browse/PIG-649
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>            Reporter: Pradeep Kamath
>            Assignee: Pradeep Kamath
>             Fix For: types_branch
>
>         Attachments: PIG-649.patch
>
>
> Currently RandomSampleLoader calls skip() on the underlying input stream (BufferedPositionedInputStream)
in its getNext(). The input stream may not actually skip over the amount the RandomSampleLoader
needs in one call. RandomSampleLoader should check the return value from the skip() call and
ensure that skip() is called repeatedly (if necessary) till the needed number of bytes are
skipped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message