hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shravan Matthur Narayanamurthy (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-553) EvalFunc.finish() not getting called
Date Fri, 23 Jan 2009 09:24:59 GMT

     [ https://issues.apache.org/jira/browse/PIG-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shravan Matthur Narayanamurthy updated PIG-553:
-----------------------------------------------

    Attachment: 553.patch

Added a Visitor(UDFFuncVisitor that calls the EvalFunc.finish() method)
Made modifications to LocalPigLauncher. After finishing plan execution, the visitor is called
to call EvalFunc.finish() on all UDFs present in the plan
Made similar modifications to PigMapBase.close(), PigMapReduce.Reduce.close(). No change to
PigCombiner.Combine.close() as only intermediate versions of the Algebraic functions are called
and only in the reduce do they finish. So the PigMapReduce.Reduce.close() takes care of that.

Another thing, is that this being a visitor call might be expensive but considering that its
done in the close method and executes once per task it should be ok I guess.

> EvalFunc.finish() not getting called
> ------------------------------------
>
>                 Key: PIG-553
>                 URL: https://issues.apache.org/jira/browse/PIG-553
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: types_branch
>         Environment: "local" mode
>            Reporter: Christopher Olston
>            Assignee: Shravan Matthur Narayanamurthy
>         Attachments: 553.patch
>
>
> My EvalFunc's finish() method doesn't seem to get invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message