hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Srinivasan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-320) The parser/type checker should use the getSchema method of UDFs to deduce return type/schema
Date Wed, 23 Jul 2008 19:17:32 GMT

    [ https://issues.apache.org/jira/browse/PIG-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616229#action_12616229
] 

Santhosh Srinivasan commented on PIG-320:
-----------------------------------------

The interface outputSchema in EvalFunc has remained unchanged from trunk. Prior to submitting
the patch, I tried to change the interface and found that it broke a whole bunch of existing
UDFs. There are two things that require a change:

1. The outputSchema method should not take any inputs. It should be outputSchema()
2. The return type of the method should be a FieldSchema and not a Schema

If we decide that these changes are required, I will go ahead and make these changes.

> The parser/type checker should use the getSchema method of UDFs to deduce return type/schema
> --------------------------------------------------------------------------------------------
>
>                 Key: PIG-320
>                 URL: https://issues.apache.org/jira/browse/PIG-320
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: types_branch
>            Reporter: Santhosh Srinivasan
>            Assignee: Santhosh Srinivasan
>             Fix For: types_branch
>
>         Attachments: udf_outputSchema.patch
>
>
> Currently, the parser/type checker uses the getReturnType to deduce the return type of
the user defined function (UDF). This mechanism is satisfactory only for basic types (int,
long, ...); for composite types (tuple, bag), the schema is also required.The abstract class
EvalFunc interface exposes the outputSchema to deduce the return type/schema of the UDF. The
parser/type checker should use this method to figure out the return type/schema of the UDF
and use it appropriately. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message