hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shravan Matthur Narayanamurthy (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-162) Rework mapreduce submission and monitoring
Date Tue, 17 Jun 2008 11:51:45 GMT

    [ https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605561#action_12605561

Shravan Matthur Narayanamurthy commented on PIG-162:

Comments on newChanges.patch:

    * test/org/apache/pig/test/TestCountExprOp.java
      i. the entire test is in the method setUp. Can the relevant portions be moved to testCount()
I will change this

    * src/org/apache/pig/impl/logicalLayer/parser/QueryParser.jjt
      i. The keyword countexpr should be count
      ii. In the method CountExpr, the function arguments to count should be like that of
Are we still doing this? I guess I remove this and submit a separate patch
"(" args=EvalArgs(over,specs,lp,input) ")"

    * src/org/apache/pig/impl/logicalLayer/LogToPhyTranslationVisitor.java
      i. public void visit(LOSplit split) is completely commented in java docs.
Well the split is not commented. But I have a new split. I will just remove that
      ii. public void visit(LOAnd op) and public void visit(LOOr op) are marked as deleted.
My mistake. Lost it during the merge. Will correct it
      iii. COUNT.java is an algebraic function wheras POCount is not. Does this have any impact?


> Rework mapreduce submission and monitoring
> ------------------------------------------
>                 Key: PIG-162
>                 URL: https://issues.apache.org/jira/browse/PIG-162
>             Project: Pig
>          Issue Type: Sub-task
>         Environment: This bug tracks works to rework the submission and monitoring interface
to map reduce as described in  http://wiki.apache.org/pig/PigTypesFunctionalSpec
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: changes.patch, changes1.patch, incr7.patch, incr8.patch, mapreduceJumbo.patch,
mapreduceJumboWithComInc.patch, modJumbo.patch, newChanges.patch, split.png, TEST-org.apache.pig.test.TestMapReduce.txt,
TEST-org.apache.pig.test.TestMRCompiler.txt, TEST-org.apache.pig.test.TestMRCompiler.txt,

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message