hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olga Natkovich (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-245) Need wrapper UDFs for all java.lang.Math functions
Date Tue, 17 Jun 2008 20:17:45 GMT

    [ https://issues.apache.org/jira/browse/PIG-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605711#action_12605711
] 

Olga Natkovich commented on PIG-245:
------------------------------------

I have applied and tested the patch. I also created javadoc and it looks really good! One
issue that I saw is that 'see also' field does not seem to be correctly set. When I built
javadoc I saw a bunch of warnings of the form:

  [javadoc] /home/olgan/src/pig-apache2/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/evaluation/math/toRadians.java:40:
warning - Tag @see: reference not found:
  [javadoc] /home/olgan/src/pig-apache2/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/evaluation/math/ULP.java:40:
warning - @see tag has no arguments.
  [javadoc] /home/olgan/src/pig-apache2/trunk/contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/evaluation/math/ULP.java:40:
warning - Tag @see: reference not found:

I will commit the patch as is since it is already very useful. It would be nice if you get
a chance to update the docs at some point.

> Need wrapper UDFs for all java.lang.Math functions
> --------------------------------------------------
>
>                 Key: PIG-245
>                 URL: https://issues.apache.org/jira/browse/PIG-245
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Shravan Matthur Narayanamurthy
>            Assignee: Shravan Matthur Narayanamurthy
>            Priority: Minor
>         Attachments: MathUDF.patch, mathudfs.zip
>
>
> Attached is the code for all the wrapper UDFs for the math functions with unit tests.
One exception is the random() function which does not take any argument. Since Pig doesn't
support zero argument udfs,  the current code takes a dummy argument which is not used in
the call to java.lang.Math.random().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message