hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (PIG-243) Make pig work on Windows
Date Thu, 29 May 2008 20:19:46 GMT

    [ https://issues.apache.org/jira/browse/PIG-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600905#action_12600905
] 

daijy edited comment on PIG-243 at 5/29/08 1:19 PM:
---------------------------------------------------------

I have tested reading one million records. Here is the result:
* On Linux, where trimming not taking place:
** Before patch: 10.53s
** After patch: 10.60s
* On Windows, where trimming branch taken:
** Before patch: 13.65s
** After patch: 13.69s

Seems that the overhead is neglectable. 

Another solution is to change the testcase rather than core code to fix this test failure.
However, I think move it to core is better. Failing to read a file in dos format (or need
extra processing) under cygwin sounds not reasonable. How do you think? 

      was (Author: daijy):
    I have tested reading one million records. Here is the result:
* On Linux, where trimming not taking place:
** Before patch: 10.53s
** After patch: 10.60s
* On Windows, where trimming branch taken:
** Before patch: 13.65s
** After patch: 13.69s

Seems that the overhead is neglectable. 

Another solution is to change the testcase rather than core code to fix this test failure.
However, I think move it to core is better. Failing to read a file in dos format under cygwin
sounds not reasonable. How do you think? 
  
> Make pig work on Windows
> ------------------------
>
>                 Key: PIG-243
>                 URL: https://issues.apache.org/jira/browse/PIG-243
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Olga Natkovich
>         Attachments: PIG_243.patch
>
>
> Currently a large number of unit tests is failing on Windows. We need to fix that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message