hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-162) Rework mapreduce submission and monitoring
Date Tue, 13 May 2008 21:13:55 GMT

    [ https://issues.apache.org/jira/browse/PIG-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596536#action_12596536

Alan Gates commented on PIG-162:

I have a question about the launcher stuff.  But I realized that a trap we were falling into
is every time you submit the patch with some new stuff, I have questions on it, so I don't
commit the patch.  Thus there's code in there that's been done for weeks but isn't checked
in and the patch is pushing on toward 1M in size.  So I removed the following classes from
the patch:  Remove MapReduceLauncher, TestJobSubmission, TestLocalJobSubmission, Launcher.java,
LocalLauncher.java and checked the rest in.

Now, on to my question:

You created a Launcher class, and then have a LocalLauncher and MapReduceLauncher that extend
it.  But the methods in Launcher (and in MapReduceLauncher) are static, so in effect MapReduceLauncher
does not really extend Launcher in any meaningful way.  Additionally, LocalLauncher is an
empty class.  Can you explain what you were trying to do here?

> Rework mapreduce submission and monitoring
> ------------------------------------------
>                 Key: PIG-162
>                 URL: https://issues.apache.org/jira/browse/PIG-162
>             Project: Pig
>          Issue Type: Sub-task
>         Environment: This bug tracks works to rework the submission and monitoring interface
to map reduce as described in  http://wiki.apache.org/pig/PigTypesFunctionalSpec
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: mapreduceJumbo.patch, mapreduceJumboWithComInc.patch, modJumbo.patch,
split.png, TEST-org.apache.pig.test.TestMRCompiler.txt, TEST-org.apache.pig.test.TestMRCompiler.txt,

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message