hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-161) Rework physical plan
Date Fri, 25 Apr 2008 17:49:56 GMT

    [ https://issues.apache.org/jira/browse/PIG-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592448#action_12592448
] 

Alan Gates commented on PIG-161:
--------------------------------

A couple of issues with incr5.patch

1) I've checked in my changes to the exceptions.  So the MergeException you added should be
changed to a PlanException.

2) MRCompiler is references GenPhyOp from the test package.  We can't do that.  The test packages
aren't included in the jar.  And we don't want it anyway.  I suspect you only need those functions
for MRCompiler, in which case you should make the relevant functions private instances inside
MRCompiler.  If they are useful outside of MRCompiler you can make GenPhyOp a class in org.apache.pig.impl.physicalLayer
(or one of its subpackages).  

3) The way OperatorKeys are being generated inside GenPhyOp won't work in main pig code (it's
fine for testing).  The scope needs to be replicated from the operators already created. 
The operator key should be generated using impl.logicalLayer.parser.NodeIdGenerator instead
of being random.

4) PhysicalPlan has a printStackTrace in the explain method.  This needs to be replaced with
proper handling of the error.

5) Do we really need to reimplement the walking functions in PlanPrinter?  Can that not be
integrated with one  of the current walkers?

> Rework physical plan
> --------------------
>
>                 Key: PIG-161
>                 URL: https://issues.apache.org/jira/browse/PIG-161
>             Project: Pig
>          Issue Type: Sub-task
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: arithmeticOperators.patch, incr2.patch, incr3.patch, incr4.patch,
incr5.patch, MRCompilerTests_PlansAndOutputs.txt, Phy_AbsClass.patch, physicalOps.patch, physicalOps.patch,
physicalOps.patch, podistinct.patch, pogenerate.patch, pogenerate.patch, pogenerate.patch,
posort.patch
>
>
> This bug tracks work to rework all of the physical operators as described in http://wiki.apache.org/pig/PigTypesFunctionalSpec

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message