hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-94) Pig Streaming functional spec proposal
Date Tue, 04 Mar 2008 23:05:41 GMT

    [ https://issues.apache.org/jira/browse/PIG-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575181#action_12575181
] 

Alan Gates commented on PIG-94:
-------------------------------

Comments:

1)  We shouldn't be using printStackTrace() anymore.

2) There should not be any System.out/err.println's in the code anymore.  These should call
log.info or log.error, as appropriate.

3) In PigExecutableManager.splitArgs(), it would be better to use Character.isSpaceChar()
or Character.isWhitespace() (I'm not clear on the difference between the two) rather than
defining SPACE as ' '.

4) There's no timeout on waiting for the user process to terminate.  This doesn't seem good.
 If the user process goes into an infinite loop we're stuck.  It seems like we need some way
to check that it's making progress (still reading input or producing output).

5) Several places it would be good to add log.debug() statements, such as when the executable
is execed, when it returns, etc.  This way developers could see the command line being passed,
the return code being returned, etc.

> Pig Streaming functional spec proposal
> --------------------------------------
>
>                 Key: PIG-94
>                 URL: https://issues.apache.org/jira/browse/PIG-94
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Olga Natkovich
>         Attachments: PIG-94_1_20080303.patch
>
>
> This issue is for discussion about Pig streaming functional spec.
> http://wiki.apache.org/pig/PigStreamingFunctionalSpec

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message