hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olga Natkovich (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-68) Improving build.xml in many ways :)
Date Sat, 23 Feb 2008 01:37:19 GMT

    [ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571677#action_12571677
] 

Olga Natkovich commented on PIG-68:
-----------------------------------

I tried to apply the patch to the latest code but it failed:

 patch -p0 </home/olgan/src/pig-apache-trunk/pig/trunk/build.xml-PIG-68-v08-SG.patch
patching file build.xml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file build.xml.rej


> Improving build.xml in many ways :)
> -----------------------------------
>
>                 Key: PIG-68
>                 URL: https://issues.apache.org/jira/browse/PIG-68
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Benjamin Francisoud
>            Priority: Minor
>         Attachments: build.xml, build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch,
build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch, build.xml-PIG-68-v05.patch, build.xml-PIG-68-v06-SG.patch,
build.xml-PIG-68-v07-SG.patch, build.xml-PIG-68-v08-SG.patch, out
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead
of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean
you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message