hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-117) commons logging and log4j
Date Mon, 25 Feb 2008 16:28:51 GMT

    [ https://issues.apache.org/jira/browse/PIG-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572119#action_12572119
] 

Alan Gates commented on PIG-117:
--------------------------------

One thought.

Does it make more sense to move log4j out of Main, or move Main out of pig.jar?  Could we
split the current pig.jar into piggrunt.jar (would contain Grunt, Main, and few other classes)
and pigserver.jar (would contain PigServer and about everything else).  This way users that
want to connect to PigServer directly can ignore all the dependencies of Grunt and we don't
have to turn Grunt into a config file driven class.  Another possible advantage is if/when
we someday move to a client server model we'll have already started the split.  The obvious
downside is we have more jars to manage and it may become harder for users to understand which
jars they need to include in order to make their stuff work.

I don't know that I have a strong opinion one way or another, but it seems worth pondering.

> commons logging and log4j
> -------------------------
>
>                 Key: PIG-117
>                 URL: https://issues.apache.org/jira/browse/PIG-117
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Stefan Groschupf
>
> On the one hand side Pig uses commons logging - what makes sense. On the other hand side
the Pig Main class configure Log4j in the code. This introduce a log4j must have dependency.

> I suggest to only use a log4j configuration file to configure log4j and remove the log4j
configuration in the code. 
> Any thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message