hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-98) grunt should show full exception stack
Date Wed, 20 Feb 2008 16:09:47 GMT

    [ https://issues.apache.org/jira/browse/PIG-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570727#action_12570727
] 

Alan Gates commented on PIG-98:
-------------------------------

With the top of trunk, the script you give above produces:

2008-02-19 16:55:14,898 [main] ERROR org.apache.pig - Error message from task (map) tip_200802061204_1977_m_000000
java.lang.NumberFormatException: For input string: "ulysses thompson"
        at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1224)
        at java.lang.Double.valueOf(Double.java:475)
        at java.lang.Double.<init>(Double.java:567)
        at org.apache.pig.data.DataAtom.numval(DataAtom.java:95)
        at org.apache.pig.impl.eval.cond.CompCond.eval(CompCond.java:77)
        at org.apache.pig.impl.eval.FilterSpec$1.add(FilterSpec.java:58)
        at org.apache.pig.impl.mapreduceExec.PigMapReduce.run(PigMapReduce.java:115)
        at org.apache.hadoop.mapred.MapTask.run(MapTask.java:192)
        at org.apache.hadoop.mapred.TaskTracker$Child.main(TaskTracker.java:1760)


This is still not useful, but at least we're giving the full stack.  I want to leave this
bug open though, because we should be giving decent error messages here (like == not valid
with string type or something).

> grunt should show full exception stack
> --------------------------------------
>
>                 Key: PIG-98
>                 URL: https://issues.apache.org/jira/browse/PIG-98
>             Project: Pig
>          Issue Type: Improvement
>          Components: grunt
>            Reporter: Stefan Groschupf
>            Priority: Minor
>             Fix For: 0.1.0
>
>         Attachments: showStackTrace-20080207.patch
>
>
> I suggest grunt should be more helpful with user errors. I just did one (a stupid one)
and it took my too long to figure out the problem, since grunts error message was just not
giving me a good hint:
> grunt> A = LOAD '/pigtestData.tsv' USING PigStorage(',') AS (user,age,cat);
> grunt> B = FILTER A BY cat == 'book';
> grunt> dump B;
> For input string: "book"
> Experts will see that I tried to use == instead of eq, however especially new users could
get a little confused. 
> I see two chances add Error Number and  descriptive texts (Oracle style) - this quite
a lot of work, or for now I suggest to simply dump the full exception text.
> At least for this early stage it would developers and users to find problems faster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message