hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Francisoud (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-80) Stacktrace information is lost at MapReduceLauncher.java:289
Date Wed, 13 Feb 2008 14:37:08 GMT

    [ https://issues.apache.org/jira/browse/PIG-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568561#action_12568561
] 

Benjamin Francisoud commented on PIG-80:
----------------------------------------

> Benjamin Reed - 12/Feb/08 09:18 AM
> 2) Found more places where it could be used

Yes I only replaced the case where the stracktrace was lost but that even better to replace
this pattern everywhere, I like DRY code ;)
Good catch.


> Stacktrace information is lost at MapReduceLauncher.java:289
> ------------------------------------------------------------
>
>                 Key: PIG-80
>                 URL: https://issues.apache.org/jira/browse/PIG-80
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.1.0
>            Reporter: Benjamin Francisoud
>            Priority: Minor
>         Attachments: PIG-80-generics.patch, PIG-80-v01.patch, PIG-80-v02.patch, PIG-80-v03.patch,
PIG-80-v04.patch, PIG-80-v05.patch
>
>
> {code:java}
> ...
> }catch (Exception e) {
>     // Do we need different handling for different exceptions
>     e.printStackTrace();
>     throw new IOException(e.getMessage());
> }finally{ ...
> {code}
> in my case the sandard output is redirtected to /dev/null so "e.printStackTrace();" is
lost.
> it should be :
> {code:java}throw new IOException(e);{code} 
> no getMessage() because we loose the rest of the stacktrace

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message