hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Francisoud (JIRA)" <j...@apache.org>
Subject [jira] Updated: (PIG-101) Use ExecType.MAPREDUCE instead of duplicate string to initialize PigServer in tests
Date Wed, 27 Feb 2008 10:51:51 GMT

     [ https://issues.apache.org/jira/browse/PIG-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benjamin Francisoud updated PIG-101:
------------------------------------

    Patch Info: [Patch Available]

changed "Patch Available" back to true since there is patchv02 now

> Use ExecType.MAPREDUCE instead of duplicate string to initialize PigServer in tests
> -----------------------------------------------------------------------------------
>
>                 Key: PIG-101
>                 URL: https://issues.apache.org/jira/browse/PIG-101
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Benjamin Francisoud
>            Priority: Trivial
>         Attachments: PIG-101-v01.patch, PIG-101-v02.patch
>
>
> In the tests code, there are lots of:
> {code:java}
> private String initString = "mapreduce";
> @Test
> public void testSomething() {
>     ....
>     PigServer pig = new PigServer(initString);
>     ....
> }
> {code}
> It could be replace with 
> {code:java}
> PigServer pig = new PigServer(ExecType.MAPREDUCE);
> {code}
> It would remove duplication in test.
> Using a string makes the tests aware of the internal PigServer behavior.
> It's really not a big deal hence the "trivial" :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message