hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] Commented: (PIG-56) implement Iterable<Tuple> in DataBag
Date Wed, 09 Jan 2008 19:18:33 GMT

    [ https://issues.apache.org/jira/browse/PIG-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557387#action_12557387
] 

Alan Gates commented on PIG-56:
-------------------------------

I have no problem with making DataBag implement Iterable.  I have a question on converting
existing code to use foreach instead of tradition for.  My impression of foreach is its syntatic
sugar.  Is there a performance motivation for switching the existing code?  If not, I'd prefer
to leave existing code alone.  Going forward developers can choose to use foreach of for as
they like.

> implement Iterable<Tuple> in DataBag
> ------------------------------------
>
>                 Key: PIG-56
>                 URL: https://issues.apache.org/jira/browse/PIG-56
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Charlie Groves
>            Priority: Minor
>         Attachments: iterable_databag.patch
>
>
> Now that DataBag has an iterator method, it can implement Iterable with no other changes.
 This would allow bags to be used in a foreach loop like 
> for(Tuple t : bag) {
>   // do something with t
> }
> The attached patch has DataBag implement iterable and converts all bag iterator usages
in pig to use foreach loops.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message