hadoop-pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nigel Daley <nda...@yahoo-inc.com>
Subject Re: question on coding style and testing
Date Wed, 07 Nov 2007 15:44:16 GMT
With tabs it's harder to enforce an (apparent) 80 character line limit.

+1 to using spaces.

On Nov 6, 2007, at 3:08 PM, Utkarsh Srivastava wrote:

> What's wrong with tabs? I hate spaces. With tabs there is less  
> probability of having messed up indentation.
>
> Utkarsh
>
>
> On Nov 6, 2007, at 3:03 PM, Benjamin Reed wrote:
>
>> Definitely no mixing tabs and spaces. We should not use tabs!
>>
>> ben
>>
>> On Tuesday 06 November 2007, Nigel Daley wrote:
>>> +1 to Alan's comments on NOT mixing tabs and spaces.  FWIW, we can
>>> enforce this with the Checkstyle tool once the current code base is
>>> fixed to follow the convention.
>>>
>>> Nige
>>>
>>> On Nov 6, 2007, at 12:11 PM, Alan Gates wrote:
>>>> I'm mostly fine with the sun conventions.  You suggested staying
>>>> with an indentation of 4.  The sun conventions say tabs must always
>>>> be set at 8.  I strongly dislike mixing tabs and spaces, as it
>>>> tends to make a mess out of code.  I don't care if we agree to do
>>>> our indents as one tab (and then let people set their tabs as they
>>>> see fit) or to only uses spaces.  But I'd like to not mix the two.
>>>>
>>>> Alan.
>>>>
>>>> Benjamin Reed wrote:
>>>>> My vote would be Sun's conventions. Hadoop uses Sun's conventions
>>>>> except for two spaces per level. It would be much better IMO to
>>>>> stick to straight Sun conventions.
>>>>>
>>>>> ben
>>>>>
>>>>> On Monday 05 November 2007 12:21:31 Olga Natkovich wrote:
>>>>>> Hi Antonio,
>>>>>>
>>>>>> My understanding is that each project develops its own style and
>>>>>> that's
>>>>>> part of the incubation process. One general rule that I think we
>>>>>> should
>>>>>> be using is that if you making changes in an existent file you
>>>>>> adhere to
>>>>>> the style of that file to preserve readability of the code. I was
>>>>>> thinking that we should be looking at the rules that hadoop is
>>>>>> using as
>>>>>> the starting point to decide what works for us and what requires
>>>>>> changes:
>>>>>>
>>>>>> http://wiki.apache.org/lucene-hadoop/
>>>>>>
>>>>>> Look at the Developer Documentation section.
>>>>>>
>>>>>> Olga
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Antonio Magnaghi [mailto:antmagna@yahoo-inc.com]
>>>>>> Sent: Monday, November 05, 2007 12:15 PM
>>>>>> To: pig-dev@incubator.apache.org
>>>>>> Subject: question on coding style and testing
>>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>>
>>>>>>
>>>>>> I have a couple of related questions about coding style/
>>>>>> guidelines and
>>>>>> unit tests.
>>>>>>
>>>>>>
>>>>>>
>>>>>> I have researched the few pages on the Apache website and was not
>>>>>> able
>>>>>> to find what I am looking for.
>>>>>>
>>>>>>
>>>>>>
>>>>>> I am curious about policies that may be in place, as I am new to
>>>>>> Apache.
>>>>>> I am wondering if there are policies in terms of coding styles  
>>>>>> like
>>>>>> naming conventions for variables, unit tests requirements,
>>>>>> possible code
>>>>>> coverage requirements (or other types of validation on check-ins
>>>>>> other
>>>>>> than peer-review).
>>>>>>
>>>>>>
>>>>>>
>>>>>> Are there general guidelines? Or maybe each single project has  
>>>>>> some
>>>>>> degree of freedom in setting up its own?
>>>>>>
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -a.
>>
>>
>


Mime
View raw message