From ozone-issues-return-16102-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Jun 18 13:44:14 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0BC0F18065B for ; Thu, 18 Jun 2020 15:44:13 +0200 (CEST) Received: (qmail 78823 invoked by uid 500); 18 Jun 2020 13:44:13 -0000 Mailing-List: contact ozone-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ozone-issues@hadoop.apache.org Delivered-To: mailing list ozone-issues@hadoop.apache.org Received: (qmail 78809 invoked by uid 99); 18 Jun 2020 13:44:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jun 2020 13:44:13 +0000 From: =?utf-8?q?GitBox?= To: ozone-issues@hadoop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bhadoop-ozone=5D_adoroszlai_commented_on_a_change_i?= =?utf-8?q?n_pull_request_=231050=3A_HDDS-3757=2E_Add_test_coverage_of_the_a?= =?utf-8?q?cceptance_tests_to_overall_test_coverage_?= Message-ID: <159248785330.8807.6031410716991797359.asfpy@gitbox.apache.org> Date: Thu, 18 Jun 2020 13:44:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: adoroszlai commented on a change in pull request #1050: URL: https://github.com/apache/hadoop-ozone/pull/1050#discussion_r442235284 ########## File path: hadoop-ozone/dist/src/main/compose/test-all.sh ########## @@ -19,17 +19,22 @@ # # Test executor to test all the compose/*/test.sh test scripts. # - SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd ) ALL_RESULT_DIR="$SCRIPT_DIR/result" - +PROJECT_DIR="$SCRIPT_DIR/.." mkdir -p "$ALL_RESULT_DIR" -rm "$ALL_RESULT_DIR/*" +rm "$ALL_RESULT_DIR/*" || true + +if [ "$OZONE_WITH_COVERAGE" ]; then + java -cp "$PROJECT_DIR"/share/coverage/$(ls "$PROJECT_DIR"/share/coverage | grep test-util):"$PROJECT_DIR"/share/coverage/jacoco-core.jar org.apache.hadoop.test.JacocoServer & + DOCKER_BRIDGE_IP=$(docker network inspect bridge --format='{{(index .IPAM.Config 0).Gateway}}') Review comment: Some of the compose environments have a dedicated network. I think those would have problems starting SCM: ``` hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml hadoop-ozone/dist/src/main/compose/ozonesecure-om-ha/docker-compose.yaml hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml ``` (I'm not sure because I have trouble starting any of the environments with coverage enabled.) ########## File path: hadoop-ozone/dist/src/main/compose/test-all.sh ########## @@ -41,8 +46,13 @@ for test in $(find "$SCRIPT_DIR" -name test.sh | sort); do echo "ERROR: Test execution of $(dirname "$test") is FAILED!!!!" fi RESULT_DIR="$(dirname "$test")/result" - cp "$RESULT_DIR"/robot-*.xml "$RESULT_DIR"/docker-*.log "$RESULT_DIR"/*.out* "$ALL_RESULT_DIR"/ + cp "$RESULT_DIR"/robot-*.xml "$RESULT_DIR"/docker-*.log "$RESULT_DIR"/*.out* "$RESULT_DIR"/*.exec "$ALL_RESULT_DIR"/ done rebot -N "smoketests" -d "$SCRIPT_DIR/result" "$SCRIPT_DIR/result/robot-*.xml" +if [ "$OZONE_WITH_COVERAGE" ]; then + cp /tmp/jacoco-combined.exec "$SCRIPT_DIR/result/" Review comment: I don't see any `*.exec` files in [acceptance.zip](https://github.com/apache/hadoop-ozone/suites/812019480/artifacts/8877510) for the latest run. Am I missing something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: ozone-issues-help@hadoop.apache.org