hadoop-ozone-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1050: HDDS-3757. Add test coverage of the acceptance tests to overall test coverage
Date Thu, 18 Jun 2020 13:44:13 GMT

adoroszlai commented on a change in pull request #1050:
URL: https://github.com/apache/hadoop-ozone/pull/1050#discussion_r442235284



##########
File path: hadoop-ozone/dist/src/main/compose/test-all.sh
##########
@@ -19,17 +19,22 @@
 #
 # Test executor to test all the compose/*/test.sh test scripts.
 #
-
 SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )
 ALL_RESULT_DIR="$SCRIPT_DIR/result"
-
+PROJECT_DIR="$SCRIPT_DIR/.."
 mkdir -p "$ALL_RESULT_DIR"
-rm "$ALL_RESULT_DIR/*"
+rm "$ALL_RESULT_DIR/*" || true
+
+if [ "$OZONE_WITH_COVERAGE" ]; then
+   java -cp "$PROJECT_DIR"/share/coverage/$(ls "$PROJECT_DIR"/share/coverage | grep test-util):"$PROJECT_DIR"/share/coverage/jacoco-core.jar
org.apache.hadoop.test.JacocoServer &
+   DOCKER_BRIDGE_IP=$(docker network inspect bridge --format='{{(index .IPAM.Config 0).Gateway}}')

Review comment:
       Some of the compose environments have a dedicated network.  I think those would have
problems starting SCM:
   
   ```
   hadoop-ozone/dist/src/main/compose/ozone-topology/docker-compose.yaml
   hadoop-ozone/dist/src/main/compose/ozonesecure-om-ha/docker-compose.yaml
   hadoop-ozone/dist/src/main/compose/ozonesecure-mr/docker-compose.yaml
   ```
   
   (I'm not sure because I have trouble starting any of the environments with coverage enabled.)

##########
File path: hadoop-ozone/dist/src/main/compose/test-all.sh
##########
@@ -41,8 +46,13 @@ for test in $(find "$SCRIPT_DIR" -name test.sh | sort); do
       echo "ERROR: Test execution of $(dirname "$test") is FAILED!!!!"
   fi
   RESULT_DIR="$(dirname "$test")/result"
-  cp "$RESULT_DIR"/robot-*.xml "$RESULT_DIR"/docker-*.log "$RESULT_DIR"/*.out* "$ALL_RESULT_DIR"/
+  cp "$RESULT_DIR"/robot-*.xml "$RESULT_DIR"/docker-*.log "$RESULT_DIR"/*.out* "$RESULT_DIR"/*.exec
"$ALL_RESULT_DIR"/
 done
 
 rebot -N "smoketests" -d "$SCRIPT_DIR/result" "$SCRIPT_DIR/result/robot-*.xml"
+if [ "$OZONE_WITH_COVERAGE" ]; then
+  cp /tmp/jacoco-combined.exec "$SCRIPT_DIR/result/"

Review comment:
       I don't see any `*.exec` files in [acceptance.zip](https://github.com/apache/hadoop-ozone/suites/812019480/artifacts/8877510)
for the latest run.  Am I missing something?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


Mime
View raw message