From ozone-issues-return-1595-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Dec 4 19:48:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CACC1180656 for ; Wed, 4 Dec 2019 20:48:48 +0100 (CET) Received: (qmail 79839 invoked by uid 500); 4 Dec 2019 19:48:48 -0000 Mailing-List: contact ozone-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ozone-issues@hadoop.apache.org Delivered-To: mailing list ozone-issues@hadoop.apache.org Received: (qmail 79827 invoked by uid 99); 4 Dec 2019 19:48:48 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2019 19:48:48 +0000 From: GitBox To: ozone-issues@hadoop.apache.org Subject: [GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #238: HDDS-2588. Consolidate compose environments Message-ID: <157548892804.23831.5458378290313800432.gitbox@gitbox.apache.org> Date: Wed, 04 Dec 2019 19:48:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anuengineer commented on a change in pull request #238: HDDS-2588. Consolidate compose environments URL: https://github.com/apache/hadoop-ozone/pull/238#discussion_r353947914 ########## File path: hadoop-ozone/dist/src/main/compose/ozone/run.sh ########## @@ -0,0 +1,20 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +declare -ix OZONE_REPLICATION_FACTOR +: ${OZONE_REPLICATION_FACTOR:=1} +docker-compose up --scale datanode=${OZONE_REPLICATION_FACTOR} --no-recreate "$@" Review comment: Well, while I agree the call for re-create is correct here. @adoroszlai You did ask the question. The issue can happen if we have a cluster that was running that has error-ed out. Then re-running this command will not reset the system. But it is probably something that we can live with, or fix much later. I predict for a long time, when someone reports an issue, we will say " make sure you kill all running docker containers". But then, traditionally that is our first debugging step whenever someone tells us that docker based stuff is not stable for them. Just to make sure, I am +1 and ok with this change. Just responding to your question; that is all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: ozone-issues-help@hadoop.apache.org