From mapreduce-issues-return-92301-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Sep 11 19:24:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5B10518067A for ; Tue, 11 Sep 2018 19:24:03 +0200 (CEST) Received: (qmail 49881 invoked by uid 500); 11 Sep 2018 17:24:02 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 49869 invoked by uid 99); 11 Sep 2018 17:24:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2018 17:24:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D8D8718FBD5 for ; Tue, 11 Sep 2018 17:24:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NnCQ8brC5Yza for ; Tue, 11 Sep 2018 17:24:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DB23A5F174 for ; Tue, 11 Sep 2018 17:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 70A2DE00D3 for ; Tue, 11 Sep 2018 17:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3021623F98 for ; Tue, 11 Sep 2018 17:24:00 +0000 (UTC) Date: Tue, 11 Sep 2018 17:24:00 +0000 (UTC) From: "Oleksandr Shevchenko (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-7136) TestMRAppMetrics should shutdown DefaultMetricsSystem after completion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-7136?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16610971#comment-16610971 ]=20 Oleksandr Shevchenko commented on MAPREDUCE-7136: ------------------------------------------------- Thank you [~jlowe] a lot for your comment. I run tests from IDE and I faced couple problem with tests. When I use fork= Mode for class these problems not appear. You are right that many tests do = not cleanup some resources since expect that will be run in separated JVM. = But I thought that tests at least from one package should pass in one JVM a= s well. Since this is the small effort to do that.=20 But if you think that is redundant and forkMode on a class is the required = condition for running Hadoop tests we can skip close this ticket. But I did= not see such requirement before. Could you kindly review other tickets which I opened (especially which are = not related to tests)? Thanks. > TestMRAppMetrics should shutdown DefaultMetricsSystem after completion > ---------------------------------------------------------------------- > > Key: MAPREDUCE-7136 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7136 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test > Reporter: Oleksandr Shevchenko > Assignee: Oleksandr Shevchenko > Priority: Minor > Attachments: MAPREDUCE-7136.001.patch, image-2018-09-10-14-39-57-= 992.png > > > TestMRAppMetrics should invoke=C2=A0shutdown method in DefaultMetricsSyst= em after completion. Since it can lead to failing other tests. For example,= =C2=A0TestRMContainerAllocator#testReportedAppProgress fails when run after= TestMRAppMetrics#testNames with the following error: > {noformat} > org.apache.hadoop.metrics2.MetricsException: Metrics source MRAppMetrics = already exists! > {noformat} > !image-2018-09-10-14-39-57-992.png! > We do not catch this on the trunk since the test TestRMContainerAllocator= #testUnsupportedMapContainerRequirement run first and "DefaultMetricsSystem= .shutdown();" invokes after completion. But since JUnit does not guarantee = the order of the tests we should fix it.=C2=A0 > Also, this is affected by previous versions which run testReportedAppPro= gress first (I faced it on 2.7.0 version). And reproduced on the trunk. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org