hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-7136) TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
Date Tue, 11 Sep 2018 18:05:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611032#comment-16611032
] 

Jason Lowe commented on MAPREDUCE-7136:
---------------------------------------

I'm fine with making a small improvement to the tests to make them easier to run in other
modes like via the IDE. I was mostly curious to learn about the use-case since that's not
how the tests will run during a normal build.  That also explains why precommit and nightly
builds have never reported this. However it's important to note problems like this are likely
to keep cropping up since JVM reuse for separate test classes is not regularly tested.

+1 for the patch, committing this.
{quote}Could you kindly review other tickets which I opened (especially which are not related
to tests)?
{quote}
I'll try to take a look at some of those this week.

> TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7136
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7136
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Minor
>         Attachments: MAPREDUCE-7136.001.patch, image-2018-09-10-14-39-57-992.png
>
>
> TestMRAppMetrics should invoke shutdown method in DefaultMetricsSystem after completion.
Since it can lead to failing other tests. For example, TestRMContainerAllocator#testReportedAppProgress
fails when run after TestMRAppMetrics#testNames with the following error:
> {noformat}
> org.apache.hadoop.metrics2.MetricsException: Metrics source MRAppMetrics already exists!
> {noformat}
> !image-2018-09-10-14-39-57-992.png!
> We do not catch this on the trunk since the test TestRMContainerAllocator#testUnsupportedMapContainerRequirement
run first and "DefaultMetricsSystem.shutdown();" invokes after completion. But since JUnit
does not guarantee the order of the tests we should fix it. 
>  Also, this is affected by previous versions which run testReportedAppProgress first
(I faced it on 2.7.0 version). And reproduced on the trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message