hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleksandr Shevchenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-7136) TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
Date Tue, 11 Sep 2018 17:24:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610971#comment-16610971
] 

Oleksandr Shevchenko commented on MAPREDUCE-7136:
-------------------------------------------------

Thank you [~jlowe] a lot for your comment.
I run tests from IDE and I faced couple problem with tests. When I use forkMode for class
these problems not appear. You are right that many tests do not cleanup some resources since
expect that will be run in separated JVM. But I thought that tests at least from one package
should pass in one JVM as well. Since this is the small effort to do that. 
But if you think that is redundant and forkMode on a class is the required condition for running
Hadoop tests we can skip close this ticket. But I did not see such requirement before.
Could you kindly review other tickets which I opened (especially which are not related to
tests)?
Thanks.

> TestMRAppMetrics should shutdown DefaultMetricsSystem after completion
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7136
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7136
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Minor
>         Attachments: MAPREDUCE-7136.001.patch, image-2018-09-10-14-39-57-992.png
>
>
> TestMRAppMetrics should invoke shutdown method in DefaultMetricsSystem after completion.
Since it can lead to failing other tests. For example, TestRMContainerAllocator#testReportedAppProgress
fails when run after TestMRAppMetrics#testNames with the following error:
> {noformat}
> org.apache.hadoop.metrics2.MetricsException: Metrics source MRAppMetrics already exists!
> {noformat}
> !image-2018-09-10-14-39-57-992.png!
> We do not catch this on the trunk since the test TestRMContainerAllocator#testUnsupportedMapContainerRequirement
run first and "DefaultMetricsSystem.shutdown();" invokes after completion. But since JUnit
does not guarantee the order of the tests we should fix it. 
>  Also, this is affected by previous versions which run testReportedAppProgress first
(I faced it on 2.7.0 version). And reproduced on the trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message