hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-7102) Fix TestJavaSerialization for Windows due a mismatch line separator
Date Sat, 02 Jun 2018 00:21:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498746#comment-16498746
] 

Íñigo Goiri commented on MAPREDUCE-7102:
----------------------------------------

Thanks [~giovanni.fumarola] for updating the description.
In addition to the try() change, we should avoid churn on the code and avoid the first two
changes in  [^MAPREDUCE-7102.v1.patch].
Another thing is that technically the test is doing the right thing but the one that generates
the text is hardcoding \n, we may want to check the source of this \n.

> Fix TestJavaSerialization for Windows due a mismatch line separator 
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-7102
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7102
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Minor
>         Attachments: MAPREDUCE-7102.v1.patch
>
>
> TestJavaSerialization#testWriteToSequencefile and testMapReduceJob fails on Windows.
> testWriteToSequencefile fails due to a missing InputStream.close() [link|https://builds.apache.org/job/hadoop-trunk-win/484/testReport/org.apache.hadoop.mapred/TestJavaSerialization/testWriteToSequencefile/] of
the test result.
> testMapReduceJob fails due to a mismatch on line separator. System.getProperty("line.separator")
in Windows is /r/n while in Linux is only /n. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message