hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-7069) Add ability to specify user environment variables individually
Date Mon, 09 Apr 2018 22:10:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431378#comment-16431378
] 

Jason Lowe commented on MAPREDUCE-7069:
---------------------------------------

Thanks for updating the patch!  Looks like TestPipeApplication and TestMRIntermediateDataEncryption
both exited abnormally.  I was not able to reproduce either failure locally with the patch
applied.

In mapred-default.xml "UEnvironment" s/b "Environment".

The example added to the tutorial is missing the "-D" flag required to be in front of all
of the example options.  These properties are not valid command-line options directly.

Nit: "alternateForm" confusd me as a parameter name to testAMStandardEnv at first, and the
comment in the method body explaining what it did was key to understanding it.  Maybe "useSeparateEnvProps"
or something similar would be a better parameter name?

Nit: It would be nice to have some whitespace between the unit test methods for readability.

I'm not sure the DockerContainers.md change is necessary.  We still support the old, single-property
way to set a list of environment variables that doesn't contain commas in the values.  I'm
not sure we need to make the example more complicated given the variable settings don't have
commas and therefore would require the separate property form.

> Add ability to specify user environment variables individually
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-7069
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7069
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Jim Brennan
>            Assignee: Jim Brennan
>            Priority: Major
>         Attachments: MAPREDUCE-7069.001.patch, MAPREDUCE-7069.002.patch, MAPREDUCE-7069.003.patch,
MAPREDUCE-7069.004.patch, MAPREDUCE-7069.005.patch
>
>
> As reported in YARN-6830, it is currently not possible to specify an environment variable
that contains commas via {{mapreduce.map.env}}, mapreduce.reduce.env, or {{mapreduce.admin.user.env}}.
> To address this, [~aw] proposed in [YARN-6830] that we add the ability to specify environment
variables individually:
> {quote}e.g, mapreduce.map.env.[foo]=bar gets turned into foo=bar
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message