From mapreduce-issues-return-91410-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Mar 22 16:10:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8D26C18067E for ; Thu, 22 Mar 2018 16:10:09 +0100 (CET) Received: (qmail 36107 invoked by uid 500); 22 Mar 2018 15:10:08 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 36096 invoked by uid 99); 22 Mar 2018 15:10:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2018 15:10:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 02309C00D6 for ; Thu, 22 Mar 2018 15:10:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5gwOfddyLCIH for ; Thu, 22 Mar 2018 15:10:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2AF685F5B3 for ; Thu, 22 Mar 2018 15:10:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3B3CAE0D83 for ; Thu, 22 Mar 2018 15:10:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8A7A2214E5 for ; Thu, 22 Mar 2018 15:10:00 +0000 (UTC) Date: Thu, 22 Mar 2018 15:10:00 +0000 (UTC) From: "Jason Lowe (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-7068) Fix Reduce Exception was overwrited by ReduceTask MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-7068?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16409685#comment-16409685 ]=20 Jason Lowe commented on MAPREDUCE-7068: --------------------------------------- Errors are much more severe than Exceptions. If we're getting something li= ke OOMError then that's arguably more important than whatever exception occ= urred in the try block. If we're worred about lack of logging of the error= , in practice the YarnUncaughtExceptionHandler is going to catch this anywa= y (installed by YarnChild when the task runs). > Fix Reduce Exception was overwrited by ReduceTask > ------------------------------------------------- > > Key: MAPREDUCE-7068 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7068 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: mrv1 > Affects Versions: 2.7.1 > Environment: CentOS 7 > Hadoop-2.7.1 > Hive-1.2.1 > Reporter: tartarus > Priority: Major > Attachments: MAPREDUCE_7068.patch > > > =C2=A0 > {code:java} > try { > //increment processed counter only if skipping feature is enabled > boolean incrProcCount =3D SkipBadRecords.getReducerMaxSkipGroups(jo= b)>0 && > SkipBadRecords.getAutoIncrReducerProcCount(job); > =20 > ReduceValuesIterator values =3D isSkipping() ?=20 > new SkippingReduceValuesIterator(rIter,=20 > comparator, keyClass, valueClass,=20 > job, reporter, umbilical) : > new ReduceValuesIterator(rIter,=20 > comparator, keyClass, valueClass, > job, reporter); > values.informReduceProgress(); > while (values.more()) { > reduceInputKeyCounter.increment(1); > reducer.reduce(values.getKey(), values, collector, reporter); > if(incrProcCount) { > reporter.incrCounter(SkipBadRecords.COUNTER_GROUP,=20 > SkipBadRecords.COUNTER_REDUCE_PROCESSED_GROUPS, 1); > } > values.nextKey(); > values.informReduceProgress(); > } > reducer.close(); > reducer =3D null; > =20 > out.close(reporter); > out =3D null; > } finally { > IOUtils.cleanupWithLogger(LOG, reducer); > closeQuietly(out, reporter); > } > } > {code} > if=C2=A0 {color:#d04437}reducer.close();{color} throw Exception , {color:= #d04437}reducer =3D null;{color} will not run, then=C2=A0{color:#d04437}IOU= tils.cleanupWithLogger(LOG, reducer);=C2=A0{color} > =C2=A0 > will throw Exception and overwrite the Exception of=C2=A0reducer.close(); > so we should catch it and print log to help targeting issues > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org