hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gergo Repas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-7030) Uploader tool should ignore symlinks to the same directory
Date Mon, 08 Jan 2018 14:54:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-7030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316430#comment-16316430
] 

Gergo Repas commented on MAPREDUCE-7030:
----------------------------------------

Thanks [~miklos.szegedi@cloudera.com] for the patch. Couple of comments:
# Regarding detecting symlinks that points to the same directory: it can be done via the nio
API, for example:
{code}
Path jarParent = jarPath.getParent();
if (jarParent.equals(jarParent.resolve(linkString).getParent().normalize())) {
{code}
This would also cover ./dir/../dir/destination, ../parentdir/destination type links.
# Currently a NotLinkException is thrown for non-symlink files, this can be avoided be changing
the {{if (ignoreSymlink)}} condition to {{if (ignoreSymlink && Files.isSymbolicLink(jar.toPath()))}}

> Uploader tool should ignore symlinks to the same directory
> ----------------------------------------------------------
>
>                 Key: MAPREDUCE-7030
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7030
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>            Priority: Minor
>         Attachments: MAPREDUCE-7030.000.patch, MAPREDUCE-7030.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message