hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Kanter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6994) Uploader tool for Distributed Cache Deploy code changes
Date Fri, 01 Dec 2017 00:09:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273697#comment-16273697

Robert Kanter commented on MAPREDUCE-6994:

The 008 patch looks good.  Just a few trivial things:
- {{beginUpload}} is marked as {{\@VisibleForTesting}} but it's also private and not used
in any tests.  We should remove the {{\@VisibleForTesting}}
- Should we set the default replication to 10?  I believe that's what's normally used by the
distributed cache.
- In {{testArguments}}, did you mean to pass {{"C"}} for the {{"-blacklist"}} argument?
- The check if {{targetPath == null}} in {{buildPackage}} seems redundant.  {{buildPackage}}
already calls {{beginUpload}}, which sets and validates it.  In fact, instead of making this
a class variable, why not simply have {{beginUpload}} return it or accept it as an argument?
 It's only ever used in these two methods.

> Uploader tool for Distributed Cache Deploy code changes
> -------------------------------------------------------
>                 Key: MAPREDUCE-6994
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6994
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>            Reporter: Miklos Szegedi
>            Assignee: Miklos Szegedi
>         Attachments: MAPREDUCE-6994.000.patch, MAPREDUCE-6994.001.patch, MAPREDUCE-6994.002.patch,
MAPREDUCE-6994.003.patch, MAPREDUCE-6994.004.patch, MAPREDUCE-6994.005.patch, MAPREDUCE-6994.006.patch,
MAPREDUCE-6994.007.patch, MAPREDUCE-6994.008.patch
> The proposal is to create a tool that collects all available jars in the Hadoop classpath
and adds them to a single tarball file. It then uploads the resulting archive to an HDFS directory.
This saves the cluster administrator from having to set this up manually for Distributed Cache

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org

View raw message