hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6972) enable try-with-resources for RecordReader
Date Fri, 29 Sep 2017 10:26:04 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185662#comment-16185662
] 

Akira Ajisaka commented on MAPREDUCE-6972:
------------------------------------------

Would you add {{@Override}} annotation to the close method? I'm +1 if that is addressed.

> enable try-with-resources for RecordReader
> ------------------------------------------
>
>                 Key: MAPREDUCE-6972
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>         Attachments: MAPREDUCE-6972.01.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}} has a close method; but doesn't implement closeable;
it would be nice to add that - it would enable to use:
> {code}
> try( org.apache.hadoop.mapred.RecordReader<?, ?> recordReader = inputFormat.getRecordReader(...
)   ){
>  [...]
> }
> {code}
> ...supporting t-w-r makes it easier to throw exceptions more safely



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message