[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850821#comment-15850821
]
Junping Du commented on MAPREDUCE-6825:
---------------------------------------
Thanks [~ctrezzo] for review! Patch LGTM too. However, there is unit test failure. [~GergelyNovak],
can you check if this is related to our code change here?
> YARNRunner#createApplicationSubmissionContext method is longer than 150 lines
> -----------------------------------------------------------------------------
>
> Key: MAPREDUCE-6825
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6825
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Chris Trezzo
> Assignee: Gergely Novák
> Priority: Trivial
> Labels: newbie
> Attachments: MAPREDUCE-6825.001.patch, MAPREDUCE-6825.002.patch
>
>
> bq. ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java:341:
public ApplicationSubmissionContext createApplicationSubmissionContext(:3: Method length is
249 lines (max allowed is 150).
> {{YARNRunner#createApplicationSubmissionContext}} is longer than 150 lines and needs
to be refactored.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org
|