hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gergely Novák (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6825) YARNRunner#createApplicationSubmissionContext method is longer than 150 lines
Date Fri, 20 Jan 2017 09:43:26 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831467#comment-15831467
] 

Gergely Novák commented on MAPREDUCE-6825:
------------------------------------------

Thanks [~ctrezzo]! I fixed all the checkstyle errors in patch #2. I don't think we should
add a unit test for this refactor, and I can't reproduce the timeout of TestMapReduceJobControl,
but I'm pretty sure it's unrelated anyway.

> YARNRunner#createApplicationSubmissionContext method is longer than 150 lines
> -----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6825
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6825
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Chris Trezzo
>            Assignee: Gergely Novák
>            Priority: Trivial
>              Labels: newbie
>         Attachments: MAPREDUCE-6825.001.patch, MAPREDUCE-6825.002.patch
>
>
> bq. ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java:341:
public ApplicationSubmissionContext createApplicationSubmissionContext(:3: Method length is
249 lines (max allowed is 150).
> {{YARNRunner#createApplicationSubmissionContext}} is longer than 150 lines and needs
to be refactored.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message