hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java
Date Thu, 27 Oct 2016 12:08:58 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611687#comment-15611687

Naganarasimha G R commented on MAPREDUCE-2631:

Thanks for the patch [~sunilg] but i have some concerns with the approach, i feel its not
required to have setting to null and check for whether its closed because it would be better
to throw exception when someone tries to write on a the stream which is already closed rather
than silently return without exception. Also there is not much optimization when we set to
the file and stream to null on close.

> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---------------------------------------------------------------
>                 Key: MAPREDUCE-2631
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>            Assignee: Sunil G
>         Attachments: 0001-MAPREDUCE-2631.patch, 0002-MAPREDUCE-2631.patch, 0003-MAPREDUCE-2631.patch,
0004-MAPREDUCE-2631.patch, MAPREDUCE-2631.0005.patch, MAPREDUCE-2631.02.patch, MAPREDUCE-2631.1.patch,
MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
>       flush();
>       file.close();
>       out.close();
>     }
> {code} 
> In the above code, if the file.close() throws any exception out will not be closed.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org

View raw message