hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6730) Use StandardCharsets instead of String overload
Date Sat, 30 Jul 2016 00:21:20 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400301#comment-15400301
] 

ASF GitHub Bot commented on MAPREDUCE-6730:
-------------------------------------------

Github user aajisaka commented on the issue:

    https://github.com/apache/hadoop/pull/114
  
    Hi @SahilKang, thank you for reporting this issue and creating the patch.
    * Would you fix the checkstyle warnings? https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6651/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
    * Would you fix org.apache.hadoop.mapred.TextOutputFormat as well?


> Use StandardCharsets instead of String overload
> -----------------------------------------------
>
>                 Key: MAPREDUCE-6730
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6730
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Sahil Kang
>            Priority: Minor
>
> In TextOutputFormat.java, instead of:
> {code:java}
> private static final String utf8 = "UTF-8";
> private static final byte[] newline;
> static {
>   try {
>     newline = "\n".getBytes(utf8);
>   } catch (UnsupportedException uee) {
>     threw new IllegalArgumentException("can't find " + utf8 + " encoding");
>   }
> }
> {code}
> Let's do something like:
> {code:java}
> private static final byte[] newline = "\n".getBytes(StandardCharsets.UTF_8);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org


Mime
View raw message