hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Trezzo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6365) Refactor JobResourceUploader#uploadFilesInternal
Date Fri, 08 Jul 2016 22:27:11 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368601#comment-15368601

Chris Trezzo commented on MAPREDUCE-6365:

[~sjlee0] The patch should be good to go and ready for review.

The two minus ones are accounted for:
# The patch does not include unit tests because it is purely a refactor with no functional
changes. The existing unit tests pass.
# There was one failed test (TestCLI#testGetJob), but that is a known flapping test and already
has a jira accounting for it (MAPREDUCE-6625). I ran the test locally and it passed.

> Refactor JobResourceUploader#uploadFilesInternal
> ------------------------------------------------
>                 Key: MAPREDUCE-6365
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6365
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Chris Trezzo
>            Assignee: Chris Trezzo
>            Priority: Minor
>         Attachments: MAPREDUCE-6365-trunk-v1.patch
> JobResourceUploader#uploadFilesInternal is a large method and there are similar pieces
of code that could probably be pulled out into separate methods.  This refactor would improve
readability of the code.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: mapreduce-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-help@hadoop.apache.org

View raw message