hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6535) TaskID default constructor results in NPE on toString()
Date Fri, 25 Mar 2016 21:11:25 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212421#comment-15212421
] 

Hudson commented on MAPREDUCE-6535:
-----------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #9500 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9500/])
MAPREDUCE-6535. TaskID default constructor results in NPE on toString(). (jlowe: rev 3f622a143c5fb15fee7e5dded99e4a4136f19810)
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/TaskID.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestTaskID.java


> TaskID default constructor results in NPE on toString()
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-6535
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6535
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.6.0
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>             Fix For: 2.9.0
>
>         Attachments: MAPREDUCE-6535.001.patch
>
>
> This code will reproduce the issue:
> {code}
> new TaskAttemptID().toString();
> {code}
> The issue is that the default constructor leaves the type {{null}}.  The {{get()}} in
{{CharTaskTypesMaps.getRepresentingCharacter()}} then throws an NPE on the null type key.
> The simplest solution would be to only call the {{get()}} on line 288 of {{TaskID.java}}
if {{type}} is not {{null}} and return some other literal otherwise.  Since no part of the
code is tripping on the NPE, what we choose for the literal shouldn't matter.  How about "x"?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message