hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6535) TaskID default constructor results in NPE on toString()
Date Thu, 24 Mar 2016 22:05:25 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211032#comment-15211032

Jason Lowe commented on MAPREDUCE-6535:

+1 lgtm.  Will commit tomorrow if there are no objections.

> TaskID default constructor results in NPE on toString()
> -------------------------------------------------------
>                 Key: MAPREDUCE-6535
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6535
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.6.0
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: MAPREDUCE-6535.001.patch
> This code will reproduce the issue:
> {code}
> new TaskAttemptID().toString();
> {code}
> The issue is that the default constructor leaves the type {{null}}.  The {{get()}} in
{{CharTaskTypesMaps.getRepresentingCharacter()}} then throws an NPE on the null type key.
> The simplest solution would be to only call the {{get()}} on line 288 of {{TaskID.java}}
if {{type}} is not {{null}} and return some other literal otherwise.  Since no part of the
code is tripping on the NPE, what we choose for the literal shouldn't matter.  How about "x"?

This message was sent by Atlassian JIRA

View raw message