Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8963718C46 for ; Thu, 28 Jan 2016 14:02:40 +0000 (UTC) Received: (qmail 19186 invoked by uid 500); 28 Jan 2016 14:02:40 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 19120 invoked by uid 500); 28 Jan 2016 14:02:40 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 19081 invoked by uid 99); 28 Jan 2016 14:02:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jan 2016 14:02:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id EDE702C1F58 for ; Thu, 28 Jan 2016 14:02:39 +0000 (UTC) Date: Thu, 28 Jan 2016 14:02:39 +0000 (UTC) From: "Akira AJISAKA (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-6616) Fail to create jobhistory file if there are some multibyte characters in the job name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121505#comment-15121505 ] Akira AJISAKA commented on MAPREDUCE-6616: ------------------------------------------ Thanks [~sarutak] for creating the patch. Mostly looks good to me. Minor nits: 1. {code} // amount size of first 5 characters < 23 // 23 < amount size of first 6 characters {code} I'm thinking we should comment why the size is equal to 22, so the above comment can be rewritten as follows: {code} // total size of the first 5 characters = 22 // 23 < total size of the first 6 characters {code} 2. {code} import static java.nio.charset.StandardCharsets.UTF_8; {code} Would you remove unnecessary whitespace between "import" and "static"? 3. {code} //NumReduces - sb.append(indexInfo.getNumReduces()); + sb.append(encodeJobHistoryFileName( + String.valueOf(indexInfo.getNumReduces()))); sb.append(DELIMITER); - + //JobStatus - sb.append(indexInfo.getJobStatus()); + sb.append(encodeJobHistoryFileName(indexInfo.getJobStatus())); sb.append(DELIMITER); - + //QueueName - sb.append(escapeDelimiters(getQueueName(indexInfo))); + sb.append(escapeDelimiters(encodeJobHistoryFileName( + getQueueName(indexInfo)))); {code} The patch includes mixed continuation indents (4 spaces and 8 spaces). Would you make the indents consistent? > Fail to create jobhistory file if there are some multibyte characters in the job name > ------------------------------------------------------------------------------------- > > Key: MAPREDUCE-6616 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6616 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: jobhistoryserver > Reporter: Akira AJISAKA > Assignee: Kousuke Saruta > Labels: i18n > Attachments: MAPREDUCE-6616-test.patch, MAPREDUCE-6616.0.patch > > > When creating jobhistory file, job name is trimmed within 50 characters by default, and the name is URL-encoded *after* the job name is trimmed. Therefore, if there are some multibyte characters in the job name, the encoded job name can be longer than 50 characters. Eventually it can break the limit of the file name (Usually 255 characters). -- This message was sent by Atlassian JIRA (v6.3.4#6332)