Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C3CB183A2 for ; Tue, 5 Jan 2016 09:12:40 +0000 (UTC) Received: (qmail 80156 invoked by uid 500); 5 Jan 2016 09:12:40 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 80091 invoked by uid 500); 5 Jan 2016 09:12:40 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 80075 invoked by uid 99); 5 Jan 2016 09:12:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 09:12:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D9A572C1F64 for ; Tue, 5 Jan 2016 09:12:39 +0000 (UTC) Date: Tue, 5 Jan 2016 09:12:39 +0000 (UTC) From: "Akira AJISAKA (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-6579) Test failure : TestNetworkedJob MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082682#comment-15082682 ] Akira AJISAKA commented on MAPREDUCE-6579: ------------------------------------------ After YARN-3946, {{JobClient.getFailureInfo()}} returns the application master's diagnostic message. Therefore the following code fails: {code} assertEquals( runningJob.getFailureInfo(),""); {code} I'm thinking the code can be replaced by {code} String diag = runningJob.getFailureInfo(); assertTrue(diag.startsWith(AMState.ACTIVATED) || diag.startsWith(AMState.ASSIGNED)); {code} because the code intend to verify that the job is not failing. By the way, the following javadoc is no longer correct. I'll update this. {code:title=o.a.h.mapreduce.JobStatus} /** * Gets any available info on the reason of failure of the job. * @return diagnostic information on why a job might have failed. */ public synchronized String getFailureInfo() { return this.failureInfo; } {code} Furthermore, I'd like to add a new method {{getDiagnostics}} to {{JobStatus}} and deprecate {{getFailureInfo}}. I'll create a separate jira for this. > Test failure : TestNetworkedJob > ------------------------------- > > Key: MAPREDUCE-6579 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6579 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Rohith Sharma K S > Assignee: Akira AJISAKA > > From [https://builds.apache.org/job/PreCommit-YARN-Build/9976/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt] TestNetworkedJob are failed intermittently. > {code} > Running org.apache.hadoop.mapred.TestNetworkedJob > Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 81.131 sec <<< FAILURE! - in org.apache.hadoop.mapred.TestNetworkedJob > testNetworkedJob(org.apache.hadoop.mapred.TestNetworkedJob) Time elapsed: 30.55 sec <<< FAILURE! > org.junit.ComparisonFailure: expected:<[[Tue Dec 15 14:02:45 +0000 2015] Application is Activated, waiting for resources to be assigned for AM. Details : AM Partition = ; Partition Resource = ; Queue's Absolute capacity = 100.0 % ; Queue's Absolute used capacity = 0.0 % ; Queue's Absolute max capacity = 100.0 % ; ]> but was:<[]> > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at org.apache.hadoop.mapred.TestNetworkedJob.testNetworkedJob(TestNetworkedJob.java:174) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)