hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lin Yiqun (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MAPREDUCE-6587) Remove unused params in connection-related methods of Fetcher
Date Wed, 23 Dec 2015 03:38:46 GMT
Lin Yiqun created MAPREDUCE-6587:
------------------------------------

             Summary: Remove unused params in connection-related methods of Fetcher
                 Key: MAPREDUCE-6587
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6587
             Project: Hadoop Map/Reduce
          Issue Type: Improvement
    Affects Versions: 2.7.1
            Reporter: Lin Yiqun
            Assignee: Lin Yiqun
            Priority: Trivial


There are some unused params in Fecther#openConnectionWithRetry.The code is following:
{code}
private void openConnectionWithRetry(MapHost host,
      Set<TaskAttemptID> remaining, URL url) throws IOException {
    long startTime = Time.monotonicNow();
    boolean shouldWait = true;
    while (shouldWait) {
      try {
        openConnection(url);
        shouldWait = false;
      } catch (IOException e) {
        if (!fetchRetryEnabled) {
           // throw exception directly if fetch's retry is not enabled
           throw e;
        }
        if ((Time.monotonicNow() - startTime) >= this.fetchRetryTimeout) {
          LOG.warn("Failed to connect to host: " + url + "after " 
              + fetchRetryTimeout + " milliseconds.");
          throw e;
        }
        try {
          Thread.sleep(this.fetchRetryInterval);
        } catch (InterruptedException e1) {
          if (stopped) {
            return;
          }
        }
      }
    }
  }
{code}
we can see that the param remaing and host is not be used in this method. So we need to remove
these param and update the method params which invoke this method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message