hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6533) testDetermineCacheVisibilities of TestClientDistributedCacheManager is broken
Date Wed, 04 Nov 2015 17:40:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990003#comment-14990003

Jason Lowe commented on MAPREDUCE-6533:

The problem is not the File constructor but rather the result when it gets turned into a URI.
 The File constructor call is building the path {{file:/Users/changli/hadoop/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target/test-dir/TestCacheVisibility}}

Since TEST_ROOT_DIR and TEST_VISIBILITY_DIR always want to be treated as {{Path}} objects
then a better fix would be to simply create them as such.  I don't see a need for the extraneous
string replacement and URI conversions.  Then it's not hardcoded on a certain path separator
and the code is cleaner.

> testDetermineCacheVisibilities of TestClientDistributedCacheManager is broken
> -----------------------------------------------------------------------------
>                 Key: MAPREDUCE-6533
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6533
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: MAPREDUCE-6533.patch

This message was sent by Atlassian JIRA

View raw message