hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chang Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6533) testDetermineCacheVisibilities of TestClientDistributedCacheManager is broken
Date Mon, 02 Nov 2015 23:20:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986258#comment-14986258
] 

Chang Li commented on MAPREDUCE-6533:
-------------------------------------

[~jlowe], thanks for review and comment concerns! Right, this broken test used to work, its
current error seem to be caused by jdk change. In the test, the {{TEST_ROOT_DIR}} is {code}file:/Users/changli/hadoop/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target/test-dir/
{code} when I run the test on my machine. But {{TEST_VISIBILITY_DIR}} is {code} file:/Users/changli/hadoop/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/file:/Users/changli/hadoop/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target/test-dir/TestCacheVisibility/{code}
which used to be {code}file:/Users/changli/hadoop/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target/test-dir/TestCacheVisibility{code}.
When a file created by {{File(String parent, String child)}}, its absolute pathname and pathname
differed as above. The {{testDetermineCacheVisibilities}} intended to test under {{file:/Users/changli/hadoop/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/target/test-dir/TestCacheVisibility}}
which is TestCacheVisibility dir under {{TEST_ROOT_DIR}}, so I reconstruct the TEST_VISIBILITY_DIR
string by this simple way rather than the unnecessarily complicate means from File to URI
then to String.

> testDetermineCacheVisibilities of TestClientDistributedCacheManager is broken
> -----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6533
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6533
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: MAPREDUCE-6533.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message