hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-3914) Mismatched free() / delete / delete [] in HadoopPipes
Date Fri, 06 Nov 2015 00:44:27 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992805#comment-14992805
] 

Hadoop QA commented on MAPREDUCE-3914:
--------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 5s {color} | {color:blue}
docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 8s {color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s {color} |
{color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s {color} |
{color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s {color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 10s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s {color} |
{color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 17s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s {color} |
{color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 17s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s {color} | {color:green}
hadoop-pipes in the patch passed with JDK v1.8.0_60. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 17s {color} | {color:green}
hadoop-pipes in the patch passed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 22s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 5m 56s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-06 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12652401/MAPREDUCE-3914.patch
|
| JIRA Issue | MAPREDUCE-3914 |
| Optional Tests |  asflicense  cc  unit  javac  compile  |
| uname | Linux 120d39c7f1be 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
|
| git revision | trunk / 286cc64 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions |  /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
|
| JDK v1.7.0_79  Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6119/testReport/
|
| modules | C: hadoop-tools/hadoop-pipes U: hadoop-tools/hadoop-pipes |
| Max memory used | 226MB |
| Powered by | Apache Yetus   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6119/console |


This message was automatically generated.



> Mismatched free() / delete / delete [] in HadoopPipes
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-3914
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3914
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: pipes
>    Affects Versions: 0.20.205.0, 0.23.0, 1.0.0
>         Environment: Based upon map reduce pipes task executed on Ubuntu 11.10
>            Reporter: Charles Earl
>              Labels: BB2015-05-TBR
>         Attachments: MAPREDUCE-3914-branch-0.23.patch, MAPREDUCE-3914-branch-1.0.patch,
MAPREDUCE-3914.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When running valgrind on a simple MapReduce pipes job, valgrind identifies a mismatched
new / delete:
> ==20394== Mismatched free() / delete / delete []
> ==20394==    at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387)
> ==20394==    by 0x4328A5: HadoopPipes::runTask(HadoopPipes::Factory const&) (HadoopPipes.cc:1171)
> ==20394==    by 0x424C33: main (ProcessRow.cpp:118)
> ==20394==  Address 0x9c5b540 is 0 bytes inside a block of size 131,072 alloc'd
> ==20394==    at 0x4C2864B: operator new[](unsigned long) (vg_replace_malloc.c:305)
> ==20394==    by 0x431E5D: HadoopPipes::runTask(HadoopPipes::Factory const&) (HadoopPipes.cc:1121)
> ==20394==    by 0x424C33: main (ProcessRow.cpp:118)
> ==20394== 
> ==20394== Mismatched free() / delete / delete []
> ==20394==    at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387)
> ==20394==    by 0x4328AF: HadoopPipes::runTask(HadoopPipes::Factory const&) (HadoopPipes.cc:1172)
> ==20394==    by 0x424C33: main (ProcessRow.cpp:118)
> ==20394==  Address 0x9c7b580 is 0 bytes inside a block of size 131,072 alloc'd
> ==20394==    at 0x4C2864B: operator new[](unsigned long) (vg_replace_malloc.c:305)
> ==20394==    by 0x431E6A: HadoopPipes::runTask(HadoopPipes::Factory const&) (HadoopPipes.cc:1122)
> ==20394==    by 0x424C33: main (ProcessRow.cpp:118)
> The new [] calls in Lines 1121 and 1122 of HadoopPipes.cc:
>         bufin = new char[bufsize];
>         bufout = new char[bufsize];
> should have matching delete [] calls but are instead bracketed my delete on lines 1171
and 1172:
>       delete bufin;
>       delete bufout;
> So these should be replaced by delete[]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message