hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6468) Consistent log severity level guards and statements in MapReduce project
Date Wed, 09 Sep 2015 15:09:46 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737006#comment-14737006
] 

Hadoop QA commented on MAPREDUCE-6468:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  22m 59s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  1s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 55s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |  10m 12s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 21s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   4m 55s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 32s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   9m  6s | The patch does not introduce any new Findbugs
(version 3.0.0) warnings. |
| {color:green}+1{color} | native |   3m 15s | Pre-build of native portion |
| {color:red}-1{color} | mapreduce tests |   8m 52s | Tests failed in hadoop-mapreduce-client-app.
|
| {color:green}+1{color} | tools/hadoop tests |   6m 23s | Tests passed in hadoop-distcp.
|
| {color:green}+1{color} | tools/hadoop tests |  14m 48s | Tests passed in hadoop-gridmix.
|
| {color:green}+1{color} | yarn tests |   6m 56s | Tests passed in hadoop-yarn-client. |
| {color:red}-1{color} | yarn tests |   0m 20s | Tests failed in hadoop-yarn-common. |
| {color:red}-1{color} | yarn tests |   0m 20s | Tests failed in hadoop-yarn-server-resourcemanager.
|
| {color:red}-1{color} | hdfs tests | 162m  1s | Tests failed in hadoop-hdfs. |
| | | 260m 30s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.mapreduce.v2.app.job.impl.TestShuffleProvider |
|   | hadoop.mapreduce.v2.app.TestJobEndNotifier |
|   | hadoop.mapreduce.v2.app.TestMRApp |
|   | hadoop.hdfs.server.blockmanagement.TestBlockManager |
| Timed out tests | org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt |
| Failed build | hadoop-yarn-common |
|   | hadoop-yarn-server-resourcemanager |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12754880/MAPREDUCE-6468-04.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0113e45 |
| hadoop-mapreduce-client-app test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
|
| hadoop-distcp test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-distcp.txt
|
| hadoop-gridmix test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-gridmix.txt
|
| hadoop-yarn-client test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-yarn-client.txt
|
| hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/testReport/
|
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5976/console |


This message was automatically generated.

> Consistent log severity level guards and statements in MapReduce project
> ------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6468
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6468
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Jackie Chang
>            Assignee: Jagadesh Kiran N
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-9995-00.patch, HADOOP-9995.patch, MAPREDUCE-6468-01.patch,
MAPREDUCE-6468-02.patch, MAPREDUCE-6468-03.patch, MAPREDUCE-6468-04.patch
>
>
> Developers use logs to do in-house debugging. These log statements are later demoted
to less severe levels and usually are guarded by their matching severity levels. However,
we do see inconsistencies in trunk. A log statement like 
> {code}
>        if (LOG.isDebugEnabled()) {
>         LOG.info("Assigned container (" + allocated + ") "
> {code}
> doesn't make much sense because the log message is actually only printed out in DEBUG-level.
We do see previous issues tried to correct this inconsistency. I am proposing a comprehensive
correction over trunk.
> Doug Cutting pointed it out in HADOOP-312: https://issues.apache.org/jira/browse/HADOOP-312?focusedCommentId=12429498&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12429498
> HDFS-1611 also corrected this inconsistency.
> This could have been avoided by switching from log4j to slf4j's {} format like CASSANDRA-625
(2010/3) and ZOOKEEPER-850 (2012/1), which gives cleaner code and slightly higher performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message