hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5045) UtilTest#isCygwin method appears to be unused
Date Tue, 22 Sep 2015 16:02:04 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902860#comment-14902860
] 

Harsh J commented on MAPREDUCE-5045:
------------------------------------

The tests under streaming appear to have failed due to a missing mockito dependency:

{code}
java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
	at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
	at org.apache.hadoop.hdfs.MiniDFSCluster.shouldWait(MiniDFSCluster.java:2489)
	at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2385)
	at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2428)
	at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1607)
	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:840)
	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:478)
	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:437)
	at org.apache.hadoop.streaming.TestDumpTypedBytes.testDumping(TestDumpTypedBytes.java:42)
{code}

This seems related to the MiniDFSCluster rather than this change. I've double confirmed there
is indeed no usage of this method, proceeding with commit.

> UtilTest#isCygwin method appears to be unused
> ---------------------------------------------
>
>                 Key: MAPREDUCE-5045
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5045
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: contrib/streaming, test
>    Affects Versions: 2.7.0
>            Reporter: Chris Nauroth
>            Assignee: Neelesh Srinivas Salian
>            Priority: Trivial
>              Labels: newbie
>         Attachments: MAPREDUCE-5045.001.patch
>
>
> Method {{UtilTest#isCygwin}} in /hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
appears to be unused.  If so, then we need to remove it.  If anything is calling it, then
we need to update the naming to isWindows, or perhaps just change call sites to use {{Shell#WINDOWS}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message