Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Sat, 22 Aug 2015 07:54:46 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12857017.1439926739000.136997.1440230086175@Atlassian.JIRA>
In-Reply-To: <JIRA.12857017.1439926739000@Atlassian.JIRA>
References: <JIRA.12857017.1439926739000@Atlassian.JIRA>
 <JIRA.12857017.1439926739082@arcas>
Subject: [jira] [Commented] (MAPREDUCE-6455) Unable to use surefire > 2.18
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-6455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707937#comment-14707937 ] 

Hudson commented on MAPREDUCE-6455:
-----------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #8338 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8338/])
MAPREDUCE-6455. Unable to use surefire > 2.18. (Charlie Helin via kasha) (kasha: rev 61bf9cae6f3882c6e9a9222f59457b9be91e3018)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java
* hadoop-mapreduce-project/CHANGES.txt


> Unable to use surefire > 2.18
> -----------------------------
>
>                 Key: MAPREDUCE-6455
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6455
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.7.1
>            Reporter: Charlie Helin
>            Assignee: Charlie Helin
>             Fix For: 3.0.0
>
>         Attachments: mr-6455.1.patch, mr-6455.2.patch, mr-6455.2.patch
>
>
> There are some compelling features in later version of surefire which lets one exclude/include tests based the content of a file, re-running of test case etc.
> However introduced in Surefire 2.18 is also https://issues.apache.org/jira/browse/SUREFIRE-649. Which changed the convention of null properties to empty string values (""). This only applies to forked tests such as the MapReduce tests and cause a couple of them to fail because of functionality that is directly or indirectly dependent on the value being null. One such example is Configuration.substituteVars() and TaskLog.getBaseLogDir().
> substituteVars() shows the issue when the getProperty returns empty String, skipping the getRaw(var) expression. One way to work around this could be
> {code} 
>    if (val == null || val.isEmpty()) {
>         String raw = getRaw(var);
>         if (raw != null) {
>           // raw contains a value, otherwise default to whatever System.getProperty returned
>           // since it could be an empty string
>           val = raw;
>         }
>       }
> {code}
> getBaseLogDir, similarly when returns an empty string the schematics of java.io.File differs dependent on whether parent is null or "". A null value is interpreted as new File(file); whereas "" will be interpreted as new File(defaultParent /* / */, file);
> This could simply be addressed with 
> {code}
>   static String getBaseLogDir() {
>     String logDir = System.getProperty("hadoop.log.dir");
>     // there is a difference how null and "" is treated as a parent
>     // directory when creating a file
>     return logDir == null || logDir.isEmpty() ? null : logDir;
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)