Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8F6F418E19 for ; Wed, 1 Jul 2015 09:49:05 +0000 (UTC) Received: (qmail 10543 invoked by uid 500); 1 Jul 2015 09:49:05 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 10478 invoked by uid 500); 1 Jul 2015 09:49:05 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 10464 invoked by uid 99); 1 Jul 2015 09:49:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 09:49:05 +0000 Date: Wed, 1 Jul 2015 09:49:05 +0000 (UTC) From: "Varun Saxena (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-5748) Potential null pointer dereference in ShuffleHandler#Shuffle#messageReceived() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Saxena updated MAPREDUCE-5748: ------------------------------------ Resolution: Not A Problem Status: Resolved (was: Patch Available) > Potential null pointer dereference in ShuffleHandler#Shuffle#messageReceived() > ------------------------------------------------------------------------------ > > Key: MAPREDUCE-5748 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5748 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Ted Yu > Assignee: Varun Saxena > Priority: Minor > Labels: BB2015-05-RFC > Attachments: 0001-MAPREDUCE-5748-Potential-null-pointer-deference-in-S.patch, MAPREDUCE-5748.02.patch, MAPREDUCE-5748.03.patch > > > Starting around line 510: > {code} > ChannelFuture lastMap = null; > for (String mapId : mapIds) { > ... > } > lastMap.addListener(metrics); > lastMap.addListener(ChannelFutureListener.CLOSE); > {code} > If mapIds is empty, lastMap would remain null, leading to NPE in addListener() call. -- This message was sent by Atlassian JIRA (v6.3.4#6332)